Skip to content

Conversation

@cuongdevjs
Copy link
Contributor

@cuongdevjs cuongdevjs commented Dec 23, 2020

  • add function convert RGBA to hex

@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #56 (d669ab5) into master (c4e9a00) will increase coverage by 4.37%.
The diff coverage is 25.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   29.68%   34.06%   +4.37%     
==========================================
  Files           3        3              
  Lines          64       91      +27     
  Branches        4        5       +1     
==========================================
+ Hits           19       31      +12     
- Misses         42       57      +15     
  Partials        3        3              
Impacted Files Coverage Δ
src/color-picker.js 5.26% <2.08%> (-3.83%) ⬇️
src/input-color.js 54.54% <33.33%> (+4.54%) ⬆️
src/utils.js 95.65% <93.75%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e9a00...d669ab5. Read the comment docs.

@wangzuo
Copy link
Member

wangzuo commented Dec 23, 2020

we use prettier with single quote, please update the pr and avoid meaningless changes.

@cuongdevjs cuongdevjs force-pushed the master branch 2 times, most recently from b9f1909 to d669ab5 Compare December 23, 2020 07:32
@wangzuo
Copy link
Member

wangzuo commented Dec 23, 2020

yes, just added the prettier.config.js file

@cuongdevjs
Copy link
Contributor Author

we use prettier with single quote, please update the pr and avoid meaningless changes.

I just updated new commit. You can review it 😄

@wangzuo
Copy link
Member

wangzuo commented Dec 23, 2020

Thank you, will check it

@wangzuo wangzuo merged commit a8a4770 into swiftcarrot:master Dec 25, 2020
@wangzuo
Copy link
Member

wangzuo commented Dec 25, 2020

I made some change based on your pr and released it in 4.0.0, let me know for any issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants