-
Notifications
You must be signed in to change notification settings - Fork 32
Add Swift SDK for Android to swift_package_test workflow #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift SDK for Android to swift_package_test workflow #172
Conversation
|
This PR will be ready to go once we have a new nightly Android SDK and some endpoint (like https://www.swift.org/api/v1/install/dev/main/android-sdk.json) to query the availability of the latest SDK. @shahmishal ping me once these are in place and I can cleanup the FIXMEs and move the PR out of draft status. |
This should be resolved now. swiftlang/swift-org-website#1196 |
It works! The last remaining FIXMEs are around the planned trimming of the "-0.1" from the download artifact name. I assume we need to wait for the next successful nightly build for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after we fix FIXME:
# FIXME: restore to main when this PR is ready to be merged
We can fix this in a future PR. |
|
OK, this is ready to go. Android tests in If we need to iterate further, we can revert to using the PR's version at |
|
Failures are expected because |
Pursuant to #83, this PR adds support for building with the Swift SDK for Android, following the precedents set by the Swift SDK for Wasm and the Static Linux SDK.
Unlike #106, this PR doesn't cover testing, which would necessitate installing and configuring an Android emulator.