Skip to content

Conversation

@marcprux
Copy link
Contributor

Pursuant to #83, this PR adds support for building with the Swift SDK for Android, following the precedents set by the Swift SDK for Wasm and the Static Linux SDK.

Unlike #106, this PR doesn't cover testing, which would necessitate installing and configuring an Android emulator.

@marcprux marcprux mentioned this pull request Oct 21, 2025
@marcprux
Copy link
Contributor Author

This PR will be ready to go once we have a new nightly Android SDK and some endpoint (like https://www.swift.org/api/v1/install/dev/main/android-sdk.json) to query the availability of the latest SDK.

@shahmishal ping me once these are in place and I can cleanup the FIXMEs and move the PR out of draft status.

@shahmishal
Copy link
Member

This PR will be ready to go once we have a new nightly Android SDK and some endpoint (like https://www.swift.org/api/v1/install/dev/main/android-sdk.json) to query the availability of the latest SDK.

@shahmishal ping me once these are in place and I can cleanup the FIXMEs and move the PR out of draft status.

This should be resolved now. swiftlang/swift-org-website#1196

@marcprux
Copy link
Contributor Author

This should be resolved now. swiftlang/swift-org-website#1196

It works!

The last remaining FIXMEs are around the planned trimming of the "-0.1" from the download artifact name. I assume we need to wait for the next successful nightly build for that?

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after we fix FIXME:

 # FIXME: restore to main when this PR is ready to be merged

@shahmishal
Copy link
Member

The last remaining FIXMEs are around the planned trimming of the "-0.1" from the download artifact name. I assume we need to wait for the next successful nightly build for that?

We can fix this in a future PR.

@marcprux marcprux marked this pull request as ready for review October 22, 2025 17:19
@marcprux marcprux requested a review from a team as a code owner October 22, 2025 17:19
@marcprux
Copy link
Contributor Author

OK, this is ready to go. Android tests in swift_package_test.yml will fail until this is merged because it is now referencing the script at swiftlang/github-workflows/refs/heads/main (https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/scripts/install-and-build-with-sdk.sh).

If we need to iterate further, we can revert to using the PR's version at swift-android-sdk/github-workflows/refs/heads/android-workflow (https://raw.githubusercontent.com/swift-android-sdk/github-workflows/refs/heads/android-workflow/.github/workflows/scripts/install-and-build-with-sdk.sh)

@shahmishal
Copy link
Member

Failures are expected because main branch does not have the script yet.

@shahmishal shahmishal merged commit 1bc3591 into swiftlang:main Oct 23, 2025
98 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants