Switch shellcheck soundness check to a lighter weight image #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
force-pushed
the
eng/PR-shellcheck
branch
from
8dc70a9 to
299a04d
Compare
jakepetroules
changed the title
This just installs and runs shellcheck. It doesn't need a 1 GB Swift toolchain image, use the much smaller baseline Ubuntu Noble variant. This makes shellcheck run faster and doesn't waste resources.
jakepetroules
force-pushed
the
eng/PR-shellcheck
branch
from
299a04d to
74f5a06
Compare
shahmishal
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just installs and runs shellcheck. It doesn't need a 1 GB Swift toolchain image; in contrast the noble image is 30 MB. This makes shellcheck run faster and doesn't waste resources.