Skip to content

WebKit checkers: recgonize @YES / @NO as safe constants (#148721) #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

WebKit checkers: recgonize @YES / @NO as safe constants (#148721) #11230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ bool tryToFindPtrOrigin(
E = unaryOp->getSubExpr();
continue;
}

if (auto *BoxedExpr = dyn_cast<ObjCBoxedExpr>(E)) {
E = BoxedExpr->getSubExpr();
continue;
}
break;
}
// Some other expression.
Expand Down
4 changes: 4 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/unretained-call-args.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,13 +329,17 @@ void foo() {
}
}

#define YES 1

Copy link

@adrian-prantl adrian-prantl Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the static analyzer tests. Is this basically implicitly checking that this new code doesn't generate an analyzer warning?

Copy link
Author

@rniwa rniwa Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

namespace call_with_cf_constant {
void bar(const NSArray *);
void baz(const NSDictionary *);
void boo(NSNumber *);
void foo() {
CFArrayCreateMutable(kCFAllocatorDefault, 10);
bar(@[@"hello"]);
baz(@{@"hello": @3});
boo(@YES);
}
}

Expand Down