[lldb] Fix handling of addresses given to swift task commands #11314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
Author
|
@swift-ci test |
Author
|
@swift-ci test macOS |
kastiglione
force-pushed
the
dl/lldb-Fix-handling-of-addresses-given-to-swift-task-commands
branch
from
84e516f to
4818f72
Compare
Author
|
@swift-ci test |
Author
|
@swift-ci test macOS |
Author
|
@swift-ci test windows |
Author
|
@swift-ci test macOS |
Author
|
the test failures are existing failures unrelated to this fix. |
kastiglione
deleted the
dl/lldb-Fix-handling-of-addresses-given-to-swift-task-commands
branch
kastiglione
added a commit
that referenced
this pull request
Sep 9, 2025
The DIL implementation of `GetValueForVariableExpressionPath` succeeds when the "variable expression path" is an integer. This code expected the old behavior, where `GetValueForVariableExpressionPath` would fail for an integer value. The fix is to try parsing the command arg as an address first (instead of as a fallback). If the command arg does not parse as an address, then it is tried as a variable expression path. rdar://159531040 (cherry picked from commit 88636f0) (cherry-picked from commit 329119d52e0004b1f73f71b01f819a05e06c4e7d)
kastiglione
added a commit
that referenced
this pull request
Sep 9, 2025
The DIL implementation of `GetValueForVariableExpressionPath` succeeds when the "variable expression path" is an integer. This code expected the old behavior, where `GetValueForVariableExpressionPath` would fail for an integer value. The fix is to try parsing the command arg as an address first (instead of as a fallback). If the command arg does not parse as an address, then it is tried as a variable expression path. rdar://159531040 (cherry picked from commit 88636f0) (cherry-picked from commit 329119d52e0004b1f73f71b01f819a05e06c4e7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DIL implementation of
GetValueForVariableExpressionPathsucceeds when the "variable expression path" is an integer. This code expected the old behavior, whereGetValueForVariableExpressionPathwould fail for an integer value.The fix is to try parsing the command arg as an address first (instead of as a fallback). If the command arg does not parse as an address, then it is tried as a variable expression path.
rdar://159531040