Fix the following CAS-related tests on Windows #11320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang :: ClangScanDeps/cas-case-sensitivity.c Clang :: ClangScanDeps/cas-fs-multiple-commands.c Clang :: ClangScanDeps/include-tree-preserve-pch-path.c
Author
|
@swift-ci please test llvm |
Author
|
Existing test failures |
cachemeifyoucan
requested review from
cachemeifyoucan and
jansvoboda11
and removed request for
jansvoboda11
cachemeifyoucan
approved these changes
Sep 4, 2025
jansvoboda11
reviewed
Sep 4, 2025
|
|
||
| // RUN: llvm-cas --cas %t/cas --ls-tree-recursive @%t/casid1 | FileCheck -check-prefix=TREE %s -DPREFIX=%/t | ||
| // RUN: llvm-cas --cas %t/cas --ls-tree-recursive @%t/casid2 | FileCheck -check-prefix=TREE %s -DPREFIX=%/t | ||
| // RUN: llvm-cas --cas %t/cas --ls-tree-recursive @%t/casid1 | FileCheck -check-prefix=TREE %s -DPREFIX=%{t-tree-/} |
There was a problem hiding this comment.
Can you explain what the difference between %/t and %{t-tree-/} is?
Author
There was a problem hiding this comment.
On Windows %{t-tree-/} has an extra prefix / like /C:/foo. tree stands for the tree path which we currently/internally define this way to handle multiple roots for Windows. No difference on non-Windows.
jansvoboda11
approved these changes
Sep 5, 2025
hjyamauchi
added a commit
that referenced
this pull request
Oct 9, 2025
Clang :: ClangScanDeps/cas-case-sensitivity.c Clang :: ClangScanDeps/cas-fs-multiple-commands.c Clang :: ClangScanDeps/include-tree-preserve-pch-path.c (Cherry picked from commit 9cf17f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following CAS-related tests on Windows
Clang :: ClangScanDeps/cas-case-sensitivity.c
Clang :: ClangScanDeps/cas-fs-multiple-commands.c
Clang :: ClangScanDeps/include-tree-preserve-pch-path.c