[lldb] Add extra verbose logging to flaky TestTsanSwiftAccessRace.py #11351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Note: it will be easier to review the first commit prior to running the formatter (which has changed many lines untouched by the first commit) |
charles-zablit
requested changes
Sep 9, 2025
lldb/test/API/functionalities/tsan/swift-access-race/TestTsanSwiftAccessRace.py
Outdated
Show resolved
Hide resolved
charles-zablit
approved these changes
Sep 9, 2025
|
Note that we don't squash commits on the swiftlang fork. You probably want to squash before merging. |
We have seen another failure of TestTsanSwiftAccessRace.py, indicating that we recieved the stop reason eStopReasonSignal rather than the expected eStopReasonInstrumentation. This alone has not been enough to diagnose the root cause of the failure. This PR adds in verbose logging, as well as capturing the value of the signal, in the hope of diagnosing the issue fully in the next occurrence.
DanBlackwell
force-pushed
the
improved-logging-lldb-testTsanSwiftAccessRace
branch
from
c7864f5 to
173d564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen another failure of TestTsanSwiftAccessRace.py, indicating that we recieved the stop reason eStopReasonSignal rather than the expected eStopReasonInstrumentation. This alone has not been enough to diagnose the root cause of the failure.
This PR adds in verbose logging, as well as capturing the value of the signal, in the hope of diagnosing the issue fully in the next occurrence.
rdar://153220781