Fix the OnDiskCASLoggerTest/MultiProcess test on Windows #11395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci please test llvm |
llvm/lib/Support/Windows/Program.inc
Outdated
| @@ -220,6 +220,10 @@ static bool Execute(ProcessInfo &PI, StringRef Program, | |||
| llvm::append_range(EnvBlock, EnvString); | |||
| EnvBlock.push_back(0); | |||
| } | |||
| // If an empty environment (*Env is size zero), we need to | |||
There was a problem hiding this comment.
Please add a test and create a PR on upstream LLVM.
Author
|
@swift-ci please test llvm |
Author
|
@swift-ci please test llvm |
cachemeifyoucan
approved these changes
Sep 18, 2025
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASLoggerTest/MultiProcess
Author
|
@swift-ci please test llvm |
Author
|
Existing failures eg. https://ci.swift.org/job/pr-apple-llvm-project-llvm-linux/1017/consoleText |
hjyamauchi
added a commit
that referenced
this pull request
Oct 9, 2025
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASLoggerTest/MultiProcess (Cherry picked from commit fccf510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the OnDiskCASLoggerTest/MultiProcess test on Windows
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASLoggerTest/MultiProcess