[LLDB] Add progress updates for reflection metadata loading #11626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
augusto2112
reviewed
Oct 13, 2025
| llvm::printEscapedString(dest, s); | ||
| return result; | ||
| }; | ||
| auto short_string = [](const std::string &dest) { |
There was a problem hiding this comment.
I don't understand what this lambda does
Author
There was a problem hiding this comment.
I added a comment:
/// Very quickly (this is a high-firing event), copy a few
/// human-readable bytes usable as detail in the progress update.
| target.ReadCStringFromMemory(addr, dest, error, force_live_memory); | ||
| if (error.Success()) { | ||
| if (m_progress_callback) | ||
| m_progress_callback(short_string(dest)); |
There was a problem hiding this comment.
Do we need something similar on readBytesImpl as well?
Author
There was a problem hiding this comment.
I only picked ReadCString because that reads something we can put into the detail field of the progress event. My understanding is that moving an indefinite progress forward by one, without a message is effectively invisible to the user.
adrian-prantl
force-pushed
the
progress-reflection
branch
from
6d1ada2 to
59221dc
Compare
When debugging locally, parsing reflection metadata is instant. But when debugging over a slow network connection the amount of memory read packets being sent back and forth can indtroduce significan delays. To meake is easier to diagnose why an operation is stalling and to provide users with feedback about what LDB is doing this patch introduces a progress update in GetSwiftRuntimTypeInfo(). LLDB only publishes at meast 1 progress event every 20ms, so this is (visually) and performance-wise a noop wehen debugging locally.
adrian-prantl
force-pushed
the
progress-reflection
branch
from
59221dc to
377e888
Compare
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging locally, parsing reflection metadata is instant. But when debugging over a slow network connection the amount of memory read packets being sent back and forth can indtroduce significan delays. To meake is easier to diagnose why an operation is stalling and to provide users with feedback about what LDB is doing this patch introduces a progress update in GetSwiftRuntimTypeInfo().
LLDB only publishes at meast 1 progress event every 20ms, so this is (visually) and performance-wise a noop wehen debugging locally.