Merge Webkit Fixes as of 2025-10-16 #11640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s::all_of as [[clang::noescape]] (llvm#158419) The checker already had std::ranges hard-coded to treat its arguments as [[clang::oescape]] but the fact std::ranges::all_of is implemented as a struct instead of a function confused the checker and resuled in a superflous warning being emitted for std::ranges::all_of. This PR adds the support for recognizing DeclRefExpr which appears as a callee in VisitCallExpr and generalizes the check in shouldTreatAllArgAsNoEscape to walk up the decl contexts to find the target namespaces such as std::ranges:: or a namespace and a function like WTF::switchOn. (cherry picked from commit 725d9e8)
Add the support for OSObjectPtr, which behaves like RetainPtr. (cherry picked from commit 9d933c7)
llvm#159705) (cherry picked from commit 86d767c)
…mplementation is seen (llvm#159947) A @interface declaration with a raw pointer @Property does not necessarily mean it synthesizes ivar of that type. To determine whether such a synthesis happens or not, we must wait for @implementation to appear. So this PR makes the checker only validate @Property then. (cherry picked from commit 321a7c3)
llvm#160986) Allow leakRef() in the return statement of an Objective-C copy method and other methods which return +1. (cherry picked from commit 103d2ca)
) Treat accessing NSApp without retaining it as safe (cherry picked from commit 872c431)
…ynthesis (llvm#162576) Don't emit a warning when an Objective-C property is defined using copy or strong semantics. (cherry picked from commit b7e256d)
Recognize ns_returns_autoreleased on a function and treat its return value as a safe pointer origin. (cherry picked from commit 0e4fb17)
…a safe pointer origin (llvm#161146) (cherry picked from commit 1127dd7)
…nd alike as trivial and returns a retained value (llvm#161135) Treat NSStringFromSelector, NSSelectorFromString, NSStringFromClass, NSClassFromString, NSStringFromProtocol, and NSProtocolFromString as trivial, and treat their return values as a safe pointer origin since the return value of these functions don't need to be retained. (cherry picked from commit b626282)
…g a parameter (llvm#160994) This PR updates the forward declaration checker so that unary operator & and * will be ignored for the purpose of determining if a given function argument is also a function argument of the caller / call-site. (cherry picked from commit e61e625)
adrian-prantl
approved these changes
Oct 16, 2025
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge WebKit static analysis fixes as of 2025-10-16.