[LLDB] Remove Swift AST-based name translation from MTC #11643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name translation only affects selectors and not classes, so it already isn't correct in all cases. The translation is implemented on top of SwiftASTContext, which is very expensive to start up and on top of that may fail if the compiler flags aren't all available. Right now the cost-benefit trade-off for this feature doesn't work out. We should look into reimplementing it on top of TypeSystemSwiftTypeRef::GetSwiftName() which uses the APINotes and ClangImporter's name translation engine to do the job. rdar://162496659 (cherry picked from commit 1b1fed2)
JDevlieghere
approved these changes
Oct 16, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name translation only affects selectors and not classes, so it already isn't correct in all cases. The translation is implemented on top of SwiftASTContext, which is very expensive to start up and on top of that may fail if the compiler flags aren't all available.
Right now the cost-benefit trade-off for this feature doesn't work out. We should look into reimplementing it on top of TypeSystemSwiftTypeRef::GetSwiftName() which uses the APINotes and ClangImporter's name translation engine to do the job.
rdar://162496659
(cherry picked from commit 1b1fed2)