Skip to content

Pass -sdk to Windows in LLDB tests #11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: stable/21.x
Choose a base branch
from
+4 −1
Draft

Pass -sdk to Windows in LLDB tests #11717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lldb/test/Shell/helper/toolchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,9 @@ def use_support_substitutions(config):
# Required in SwiftREPL tests
sdk_path = os.environ.get("SDKROOT")
if sdk_path:
# Wrap in quotes so that paths with spaces don't get mangled into
# multiple arguments when used as an arg.
sdk_path = f"'{sdk_path}'"
llvm_config.lit_config.note(f"using SDKROOT: {sdk_path}")
llvm_config.with_environment("SDKROOT", sdk_path)
else:
Expand All @@ -258,7 +261,7 @@ def use_support_substitutions(config):
),
]
swift_driver_args = []
if platform.system() in ["Darwin"]:
if platform.system() in ["Darwin", "Windows"]:
swift_args += ["-sdk", sdk_path]
tools = [
ToolSubst(
Expand Down