[lldb] Correctly detach (rather than kill) when connecting with gdb-remote #11790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
Author
@swift-ci test macos |
Author
|
@swift-ci test windows |
JDevlieghere
force-pushed
the
jdevlieghere/radar/156111423
branch
from
3bb4829 to
918e6a6
Compare
Author
|
@swift-ci test |
While debugging the tests for llvm#155000 I found it helpful to have both sides of the simulated gdb-rsp traffic rather than just the responses so I've extended the packetLog in MockGDBServerResponder to record traffic in both directions. Tests have been updated accordingly (cherry picked from commit f188c97)
…emote (llvm#166869) We weren't setting `m_should_detach` when going through the `DoConnectRemote` code path. This meant that when you would attaches to a remote process with `gdb-remote <port>` and use Ctrl+D, it would kill the process instead of detach from it. rdar://156111423 (cherry picked from commit cce1055)
JDevlieghere
force-pushed
the
jdevlieghere/radar/156111423
branch
from
918e6a6 to
2612b02
Compare
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't setting
m_should_detachwhen going through theDoConnectRemotecode path. This meant that when you would attaches to a remote process withgdb-remote <port>and use Ctrl+D, it would kill the process instead of detach from it.rdar://156111423
(cherry picked from commit cce1055)