Skip to content

Conversation

NuriAmari
Copy link

The test was failing as a result of a malformed glob in the UNSUPPORTED directive.

Replace with UNSUPPORTED target={{.*}} to disable the test on all platforms, which I assume was the intent.

Before:

UNRESOLVED: Clang :: Driver/lld-repro.c (1 of 1)
******************** TEST 'Clang :: Driver/lld-repro.c' FAILED ********************
Exception during script execution:
Traceback (most recent call last):
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 32, in evaluate
    return parser.parseAll()
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 151, in parseAll
    self.token = next(self.tokens)
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 62, in tokenize
    raise ValueError("couldn't parse text: %r" % string)
ValueError: couldn't parse text: '*'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/Test.py", line 406, in getUnsupportedFeatures
    return [
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/Test.py", line 409, in <listcomp>
    if BooleanExpression.evaluate(item, features)
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 34, in evaluate
    raise ValueError(str(e) + ("\nin expression: %r" % string))
ValueError: couldn't parse text: '*'
in expression: '*'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/worker.py", line 76, in _execute_test_handle_errors
    result = test.config.test_format.execute(test, lit_config)
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/formats/shtest.py", line 29, in execute
    return lit.TestRunner.executeShTest(
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2096, in executeShTest
    parsed = parseIntegratedTestScript(test, require_script=not script)
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2014, in parseIntegratedTestScript
    unsupported_features = test.getUnsupportedFeatures()
  File "/home/nuriamari/git/swift-project/llvm-project/llvm/utils/lit/lit/Test.py", line 412, in getUnsupportedFeatures
    raise ValueError("Error in UNSUPPORTED list:\n%s" % str(e))
ValueError: Error in UNSUPPORTED list:
couldn't parse text: '*'
in expression: '*'

The test was failing as a result of a malformed glob in the
UNSUPPORTED directive.

Replace with `UNSUPPORTED target={{.*}}` to disable the
test on all platforms, which I assume was the intent.
@kubamracek
Copy link

Thanks for fixing this!

@NuriAmari
Copy link
Author

@kubamracek Do you mind merging, I can't merge into Apple's LLVM fork.

@kubamracek
Copy link

@swift-ci please test

@kubamracek kubamracek merged commit e7da2ca into swiftlang:stable/20230725 Apr 10, 2024
@NuriAmari NuriAmari deleted the fix-check-clang branch June 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants