[lldb] Drop LOG_CONS from openlog call. #9002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't pass `LOG_CONS` to the openlog call. > Write directly to the system console if there is an error while > sending to the system logger. This seemed like a good idea at the time, but it turns out to be extremely annoying when this happens and LLDB is overwhelmed by log messages in the console. rdar://132243490 (cherry picked from commit 34e67ff)
Author
|
@swift-ci test |
kastiglione
approved these changes
Jul 23, 2024
fredriss
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass
LOG_CONSto the openlog call.This seemed like a good idea at the time, but it turns out to be extremely annoying when this happens and LLDB is overwhelmed by log messages in the console.
rdar://132243490
(cherry picked from commit 34e67ff)