Skip to content

Conversation

@ian-twilightcoder
Copy link

The upcoming Apple SDK releases will support the clang built-in headers being in the clang built-in modules: stop passing -fbuiltin-headers-in-system-modules for those SDK versions.

rdar://116490661

…es for the upcoming Apple releases

The upcoming Apple SDK releases will support the clang built-in headers being in the clang built-in modules: stop passing -fbuiltin-headers-in-system-modules for those SDK versions.

rdar://116490661
@ian-twilightcoder
Copy link
Author

Explanation: This change is required for open source clang to be able to work with the SDKs in Xcode 16 beta 5 and beyond. (It will break compatibility for the earlier betas, but not the earlier releases.)
Radar (and possibly SR Issue): rdar://116490661
Scope: This affects compiling against the Xcode 16 beta SDKs, it does not affect previous (Xcode 15 and earlier) SDKs.
Risk: None anticipated.
Testing: Local testing, CI.
Reviewed By: Cyndy Ishida (cyndyishida)

@ian-twilightcoder
Copy link
Author

@swift-ci test llvm

@ian-twilightcoder
Copy link
Author

@swift-ci test

@ian-twilightcoder
Copy link
Author

All of the Linux llvm test failures are known failures:

clang: error: unknown argument '-emit-llvm-only'; did you mean '-Xclang -emit-llvm-only'?

@ian-twilightcoder
Copy link
Author

All of the Linux llvm test failures are known failures:

clang: error: unknown argument '-emit-llvm-only'; did you mean '-Xclang -emit-llvm-only'?

Same for all of the macOS llvm test failures.

This patch fixes:

  clang/lib/Driver/ToolChains/Darwin.cpp:2937:3: error: default label
  in switch which covers all enumeration values
  [-Werror,-Wcovered-switch-default]
@ian-twilightcoder
Copy link
Author

@swift-ci test llvm

@ian-twilightcoder
Copy link
Author

@swift-ci test

@fredriss fredriss merged commit a0bfc8c into swiftlang:swift/release/6.0 Aug 9, 2024
@ian-twilightcoder ian-twilightcoder deleted the enable_builtin_modules branch August 9, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants