🍒[Clang] Dispatch default overloads of TemplateArgumentVisitor to the implementation
#9554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e implementation This fixes an issue where overriding `clang::ConstTemplateArgumentVisitor::VisitTemplateArgument` in an implementation visitor class did not have the desired effect: the overload was not invoked when one of the visitor methods (e.g. `VisitDeclarationArgument`) is not implemented, instead it dispatched to `clang::ConstTemplateArgumentVisitor::VisitTemplateArgument` itself and always returned a default-initialized result. This makes `TemplateArgumentVisitor` and `ConstTemplateArgumentVisitor` follow the implicit convention that is followed elsewhere in Clang AST, in `RecursiveASTVisitor` and `TypeVisitor`. (cherry picked from commit d4525b0)
Author
|
@swift-ci please test LLVM |
Author
|
@swift-ci please test |
Xazax-hun
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where overriding
clang::ConstTemplateArgumentVisitor::VisitTemplateArgumentin an implementation visitor class did not have the desired effect: the overload was not invoked when one of the visitor methods (e.g.VisitDeclarationArgument) is not implemented, instead it dispatched toclang::ConstTemplateArgumentVisitor::VisitTemplateArgumentitself and always returned a default-initialized result.This makes
TemplateArgumentVisitorandConstTemplateArgumentVisitorfollow the implicit convention that is followed elsewhere in Clang AST, inRecursiveASTVisitorandTypeVisitor.(cherry picked from commit d4525b0)