[cxx-interop][LLDB] Update test for variadic templates, part 1 #9561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
force-pushed
the
egorzhdan/20240723-cxx-interop-test
branch
4 times, most recently
from
925d16e to
099ec53
Compare
C++ class template instantiations previously did not get a valid generated Swift type name if they used variadic generics. See swiftlang/swift#77450. Since fully enabling the test requires the Swift PR to be merged, and the Swift PR relies on this test passing, this PR temporarily disables the failing asserts. rdar://139435937 rdar://106459037
egorzhdan
force-pushed
the
egorzhdan/20240723-cxx-interop-test
branch
from
099ec53 to
77f4603
Compare
egorzhdan
changed the title
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ class template instantiations previously did not get a valid generated Swift type name if they used variadic generics.
See swiftlang/swift#77450.
Since fully enabling the test requires the Swift PR to be merged, and the Swift PR relies on this test passing, this PR temporarily disables the failing asserts.
rdar://139435937
rdar://106459037