Skip to content

[SR-10809] Honour ClientCapabilities for code completion snippets #546

@benlangmuir

Description

@benlangmuir
Previous ID SR-10809
Radar None
Original Reporter @benlangmuir
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s SourceKit-LSP
Labels Bug, StarterBug
Assignee rockbruno (JIRA)
Priority Medium

md5: 9dd1bf0b87599da59d5dbf4174138ac3

Issue Description:

We currently always return code-completion items with snippets. However, this is supposed to be configurable by the client/editor using

TextDocumentClientCapabilities
> completion
> completionItem
> snippetSupport

https://microsoft.github.io/language-server-protocol/specification#initialize

We should honour that capability, and when the editor does not support snippets, strip them out before returning the completion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions