Skip to content

Ensure that edits have been processed before trying to observe them in a cross-file completion #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Ensure that edits have been processed before trying to observe them in a cross-file completion #2307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Tests/SourceKitLSPTests/SwiftCompletionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,9 @@ final class SwiftCompletionTests: XCTestCase {
)
)

// Synchronize to make sure that the edit to Second.swift has been processed since opening First.swift and the
// completion request do not have any dependencies on the edit of Second.swift.
try await project.testClient.send(SynchronizeRequest())
let (firstUri, firstPositions) = try project.openDocument("First.swift")
let completions = try await project.testClient.send(
CompletionRequest(textDocument: TextDocumentIdentifier(firstUri), position: firstPositions["1️⃣"])
Expand Down