Avoid crashing when loading client plugins from the same path #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
rintaro
approved these changes
Sep 26, 2025
When `DYLD_(FRAMEWORK|LIBRARY)_PATH` is set, `dlopen` will first check if the basename of the provided path is within any of its search paths. Thus it's possible that only a single library is loaded for each toolchain, rather than a separate like we expect. The paths should be equal in this case, since the client plugin is loaded based on the path of `sourcekitd.framework` (and we should only have one for the same reason). Allow this case and just avoid re-initializing.
bnbarham
force-pushed
the
remove-precondition
branch
from
e5ccfc5 to
add109d
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
ahoppen
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DYLD_(FRAMEWORK|LIBRARY)_PATHis set,dlopenwill first check if the basename of the provided path is within any of its search paths. Thus it's possible that only a single library is loaded for each toolchain, rather than a separate like we expect. The paths should be equal in this case, since the client plugin is loaded based on the path ofsourcekitd.framework(and we should only have one for the same reason). Allow this case and just avoid re-initializing.