Skip to content

Allow double dash for IndexStore-related CLI arguments #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Allow double dash for IndexStore-related CLI arguments #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fb1a8e
Allow double dash for IndexStore-related CLI arguments
MaxDesiatov Sep 2, 2020
8145889
Require ArgumentParser 0.3.1 in Package.swift
MaxDesiatov Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ if getenv("SWIFTCI_USE_LOCAL_DEPS") == nil {
.package(url: "https://github.com/apple/indexstore-db.git", .branch("master")),
.package(url: "https://github.com/apple/swift-package-manager.git", .branch("master")),
.package(url: "https://github.com/apple/swift-tools-support-core.git", .branch("master")),
.package(url: "https://github.com/apple/swift-argument-parser.git", .upToNextMinor(from: "0.3.0")),
.package(url: "https://github.com/apple/swift-argument-parser.git", .upToNextMinor(from: "0.3.1")),
]
} else {
package.dependencies += [
Expand Down
8 changes: 4 additions & 4 deletions Sources/sourcekit-lsp/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,16 @@ struct Main: ParsableCommand {
var clangdOptions = [String]()

@Option(
name: .customLong("index-store-path", withSingleDash: true),
name: [.long, .customLong("index-store-path", withSingleDash: true)],
help: "Override index-store-path from the build system"
)
var indexStorePath: AbsolutePath?

@Option(
name: .customLong("index-db-path", withSingleDash: true),
name: [.long, .customLong("index-db-path", withSingleDash: true)],
help: "Override index-database-path from the build system"
)
var indexDatabasePath: AbsolutePath?
var indexDBPath: AbsolutePath?

@Option(
help: "Whether to enable server-side filtering in code-completion"
Expand All @@ -135,7 +135,7 @@ struct Main: ParsableCommand {
serverOptions.buildSetup.flags.swiftCompilerFlags = buildFlagsSwift
serverOptions.clangdOptions = clangdOptions
serverOptions.indexOptions.indexStorePath = indexStorePath
serverOptions.indexOptions.indexDatabasePath = indexDatabasePath
serverOptions.indexOptions.indexDatabasePath = indexDBPath
serverOptions.completionOptions.serverSideFiltering = completionServerSideFiltering
serverOptions.completionOptions.maxResults = completionMaxResults

Expand Down