build: pin argument-parser to 0.3.0 #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the change in swiftlang/swift-package-manager#2909. Without this change, it is not possible to build SourceKit-LSP without the local dependencies as the version conflict prevents a resolution. Thanks to @owenv for pointing out the change in s-p-m!
|
@swift-ci please test |
|
This would probably break #306, which I think only works with 0.3.1. @natecook1000 would you mind confirming this please? As far as I understand, the API is the same in 0.3.0 and 0.3.1 as required by semantic versioning, but a bug in 0.3.0 prevents it from working correctly? |
|
Unfortunately, building s-p-m against s-a-p 0.3.1 fails due to an assertion triggering. Right now, it is not possible to build SK-LSP as s-p-m pins to =0.3.0 and SK pins to >=0.3.1. |
|
As @MaxDesiatov said, this change is not compatible for #306. I confirmed that it crashes trying to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the change in swiftlang/swift-package-manager#2909. Without
this change, it is not possible to build SourceKit-LSP without the local
dependencies as the version conflict prevents a resolution.
Thanks to @owenv for pointing out the change in s-p-m!