Ensure long paths are handled correctly in calls to Win32 APIs #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
Collaborator
Author
|
@swift-ci test |
Collaborator
Author
|
Same approach as in apple/swift-system#226 |
compnerd
reviewed
Apr 20, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
I think that the FSProxy is better adjusted to simply use Foundation's FileManager for these operations rather than re-implementing them.
Collaborator
Author
|
Sure, I can do that for the FSProxy bits. Still need our own copy of "withNTPathRepresentation" for LoadLibraryW and any other Win32 APIs we might need to directly call in future which don't have Foundation analogues. I also fixed up the path handling in Foundation itself, take a look: swiftlang/swift-foundation#1257 |
jakepetroules
force-pushed
the
windows-paths
branch
from
bfb3b33 to
664c7d7
Compare
Collaborator
Author
|
Moved the FSProxy changes into #427, as far as existing code goes, this is now just the one-line change to LoadLibraryW. |
Collaborator
Author
|
@swift-ci test |
jakepetroules
force-pushed
the
windows-paths
branch
from
664c7d7 to
acc4472
Compare
Collaborator
Author
|
@swift-ci test |
neonichu
approved these changes
Apr 22, 2025
Use the same technique being proposed in SwiftSystem and partly-implemented in Foundation. As a follow-on change, we also need to stop using POSIX filesystem APIs, which are not Unicode or long path aware.
jakepetroules
force-pushed
the
windows-paths
branch
from
acc4472 to
3403a24
Compare
Collaborator
Author
|
@swift-ci test |
compnerd
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same technique being proposed in SwiftSystem and partly-implemented in Foundation.
As a follow-on change, we also need to stop using POSIX filesystem APIs, which are not Unicode or long path aware.