A couple incremental entitlements processing / signing fixes #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
owenv
commented
Nov 15, 2025
owenv
commented
- Ensure we regenerate the build description on every entitlements change, because it records a timestamp of the file to diagnose modifications during the build
- Ensure irrelevant settings changes do not invalidate entitlements processing
This avoids incorrectly diagnosing an entitlements change during the build.
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
Collaborator
Author
|
@swift-ci test |
jakepetroules
approved these changes
Nov 16, 2025
| public final class ProcessProductEntitlementsTaskAction: TaskAction | ||
| { | ||
| /// The scope the task should use to evaluate build settings. | ||
| let scope: MacroEvaluationScope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.