Correct linker file list escaping depending on the LINKER_DRIVER used #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
Collaborator
Author
|
@swift-ci test |
owenv
force-pushed
the
owenv/driver-format
branch
from
7611e89 to
5b73823
Compare
Collaborator
Author
|
@swift-ci test |
jakepetroules
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKER_DRIVER=clang invocations need to use different formatting compared to LINKER_DRIVER=swiftc, and Libtool formatting should be independently configurable. Fixes issues reported in #333