[SR-2981] Adding empty array to URLComponents queryItems adds a unnecessary '?' to the end of the URL

[swift-ci]

Previous ID	SR-2981
Radar	None
Original Reporter	madsbogeskov (JIRA User)
Type	Bug
Status	Closed
Resolution	Won't Do

Attachment: Download

Additional Detail from JIRA

Votes	0
Component/s	Foundation
Labels	Bug
Assignee	mattrajca (JIRA)
Priority	Medium

md5: d0bedad00d4be1f3856ee128bfd0a58c

Issue Description:

var components = URLComponents(string: "https://www.lego.com")!
print(components.url!)
// this prints "https://www.lego.com\n"
components.queryItems = []
print(components.url!)
// this prints "https://www.lego.com?\n"
components.queryItems = nil
print(components.url!)
// this prints "https://www.lego.com\n"

There is no reason that there should be any difference between the empty and nil array in this case.

[belkadan]

This is of course up to Foundation, but I would argue that the behavior is correct. While a URL should not distinguish between a present-but-empty query section and an absent one, URLComponents should be able to represent that difference.

[swift-ci]

Comment by Mads Bøgeskov (JIRA)

Ok. Then ill close the bug @belkadan