Port: Android build fixes #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues seen in https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=6297&view=logs&j=1d59321a-8fbc-5405-c03e-4696bd0a260e&t=1075a828-3280-5930-19a8-eb2ba31fb39b&l=805: - INADDR_ANY is not necessarily available on Android. - Cast INADDR_* values to in_addr_t before assignment. - Android imports SOCK_* as untyped Int32 values; do not invoke .rawValue on them in that case.
Contributor
Author
Contributor
Author
|
@swift-ci please test |
Member
|
Android build test at https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=6308 with swiftlang/swift-corelibs-libdispatch#510 |
Member
|
Repairs the build for android ARM, ARM64, and x64! |
compnerd
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues seen in https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=6297&view=logs&j=1d59321a-8fbc-5405-c03e-4696bd0a260e&t=1075a828-3280-5930-19a8-eb2ba31fb39b&l=805:
INADDR_ANYis not necessarily available on Android.INADDR_*values toin_addr_tbefore assignment.SOCK_*as untypedInt32values; do not invoke.rawValueon them in that case.