SR-794 pass supplied subpath through to URLForResource rather than nil #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. Will run through tests then we can merge. |
Contributor
|
@swift-ci please test |
phausler
added a commit
that referenced
this pull request
Mar 7, 2016
SR-794 pass supplied subpath through to URLForResource rather than nil
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-794 reports an issue with
NSBundle.pathForResource()whereby it returnsnilinstead of the expected resource.It looks like this is cause because the supplied
subpathvalue isn't passed down to the underlyingURLForResource()call.I've fixed that and added an implementation of the test case to TestNSBundle. I've done that under the existing
test_URLsForResourcesWithExtension()test as a separate call and check as its a similar test and reuses the same bundle setup/teardown. I can spin it off as a separate test though if it makes sense.