Replace all bridge() calls with corresponding as expression in test cases #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased changes to current master and resolved conflicts. Once pre-req pull requests are merged this on is now ready to go as well. Current output of running the tests is (as expected): Test Suite 'TestFoundation.xctest' passed at 18:29:48.893 |
|
obsolete / no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces all bridge() calls in TestFoundation with the corresponding 'as' expressions. It gets the same test results (Total executed 395 tests, with 1 failure (0 unexpected)) as an unmodified test suite.
Opening pull request for discussion. I'm a bit behind the master branch of foundation because of the current problems with build stability. Once things stabilize, I will rebase/merge as needed.
This pull request assumes that Swift pull request swiftlang/swift#1994 and Foundation pull request #303 have been applied.