Swift3: SR-3002: DispatchData.enumerateBytes on Linux leaks the block #189
+5
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid leaking the block parameter of enumerateBytes, we need to directly call CDispatch.dispatch_data_apply (not _swift_dispatch_data_apply). However, we need to tell the compiler that the internal closure that translates between the C and Swift layers will not cause the captured block parameter to escape. If SR-2313 were implemented, we could use withoutActuallyEscaping. Since withoutActuallyEscaping is not available, we instead use unsafeBitCast to bypass the compiler's analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid leaking the block parameter of enumerateBytes,
we need to directly call CDispatch.dispatch_data_apply
(not _swift_dispatch_data_apply). However, we need to tell
the compiler that the internal closure that translates between
the C and Swift layers will not cause the captured block
parameter to escape. If SR-2313 were implemented, we could use
withoutActuallyEscaping. Since withoutActuallyEscaping is not available,
we instead use unsafeBitCast to bypass the compiler's analysis.