use reserved spelling for inline assembly #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
Member
Author
Contributor
MadCoder
suggested changes
Feb 16, 2018
Contributor
MadCoder
left a comment
MadCoder
left a comment
There was a problem hiding this comment.
please use __asm__ __volatile__ if you're doing this then, because it's weird to only do half.
Use the reserved spelling for `asm` as it is a non-standard compiler extension. Rather than trying to enumerate the user label prefix on the various targets, rely on the compiler. The GNU compilers define `__USER_LABEL_PREFIX__` to "_" as appropriate. In the case that you are using a non-GNU compiler, it is possible to specify the macro according to your target. This simplifies and unifies the code.
compnerd
force-pushed
the
reserved-asm
branch
from
98cafa0 to
40a19da
Compare
Member
Author
|
@MadCoder updated to use |
Member
Author
|
@swift-ci please test |
Use the reserved spelling for `typeof` as it is a non-standard compiler extension. NFC.
Member
Author
|
Actually, let me merge in the reserved spelling for |
Contributor
|
this is fine :) |
Contributor
|
@swift-ci please test |
Member
Author
|
@MadCoder anything else for this change or good to merge? |
MadCoder
approved these changes
Feb 17, 2018
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
use reserved spelling for inline assembly Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the reserved spelling for
asmas it is a non-standard compilerextension. NFC.