shims: fix TAILQ_CONCAT() edge cases #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to set the `te_next` of the last element in `head1` and also handle the case where `head1` is empty. This fixes a hang in the dispatch_context_for_key test on Windows because the the queue-specific list was getting corrupted in `_dispatch_queue_specific_head_dispose()`.
Contributor
Author
Member
|
@swift-ci please test |
ktopley-apple
approved these changes
Jun 12, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
shims: fix TAILQ_CONCAT() edge cases Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to set the
te_nextof the last element inhead1and alsohandle the case where
head1is empty. This fixes a hang in thedispatch_context_for_key test on Windows because the the queue-specific
list was getting corrupted in
_dispatch_queue_specific_head_dispose().