shims: use the precise Windows time functions #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_dispatch_uptime()` and `_dispatch_monotonic_time()` are currently using interrupt time APIs which return values cached by the scheduler. This is causing the dispatch_after test to fail on Windows. Switch them to the "Precise" APIs which incorporate a hardware time reading into their results. Unfortunately, these functions are not exported by any import libraries and we have to locate them at runtime. Also, `_dispatch_monotonic_time()` should not be using the unbiased version of the API because it is expected to include suspend time.
Contributor
Author
compnerd
reviewed
Jun 13, 2019
Member
|
@swift-ci please test |
ktopley-apple
approved these changes
Jun 13, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
shims: use the precise Windows time functions Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_dispatch_uptime()and_dispatch_monotonic_time()are currentlyusing interrupt time APIs which return values cached by the scheduler.
This is causing the dispatch_after test to fail on Windows. Switch them
to the "Precise" APIs which incorporate a hardware time reading into
their results. Unfortunately, these functions are not exported by any
import libraries and we have to locate them at runtime.
Also,
_dispatch_monotonic_time()should not be using the unbiasedversion of the API because it is expected to include suspend time.