hw_config: fix Windows CPU detection #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
The Windows CPU detection code is not reporting the intended values. `physical_cpus` should report the number of physical cores instead of the number of packages, and `active_cpus` should report the number of available logical cores instead of the number of available physical cores. This fixes an issue where the `dispatch_apply` test times out on hyperthreaded systems.
Member
|
@swift-ci please test |
Member
ktopley-apple
approved these changes
Sep 23, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
hw_config: fix Windows CPU detection Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows CPU detection code is not reporting the intended values.
physical_cpusshould report the number of physical cores instead ofthe number of packages, and
active_cpusshould report the number ofavailable logical cores instead of the number of available physical
cores. This fixes an issue where the
dispatch_applytest times out onhyperthreaded systems.