BlocksRuntime: Expose NSConcrete* globals on Win32 #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbkka is working on moving the blocks runtime out of swift-corelibs-libdispatch to the new swift-corelibs-blocksruntime repo. I think we might want to hold off on this or move this change to the new repo. |
|
Yes, please file a PR against |
|
@swift-ci Please test |
|
I'm not sure that this is the right approach. I've fixed the code generation on clang to handle this properly. We should be able to undo the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libobjc2 now supports external blocks runtimes, including the one bundled in libdispatch. This works on Linux, but the NSConcrete* globals are not correctly exposed on Windows resulting in a linker error. @compnerd added initial support for this in 23ce6f6. I have added the remaining globals to this.