-
Notifications
You must be signed in to change notification settings - Fork 163
Update swift-argument-parser #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#32 @swift-ci Please test |
This also removes support for parsing unknown arguments in `docc convert`
67ccec1 to
9c5f895
Compare
Contributor
Author
|
#32 @swift-ci Please test |
d-ronnqvist
approved these changes
Nov 9, 2021
Contributor
d-ronnqvist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ethan-kusters
approved these changes
Nov 9, 2021
shahmishal
added a commit
that referenced
this pull request
Nov 10, 2021
This reverts commit a8a9b4a.
shahmishal
added a commit
that referenced
this pull request
Nov 10, 2021
jakepetroules
added a commit
that referenced
this pull request
Nov 10, 2021
shahmishal
pushed a commit
that referenced
this pull request
Nov 10, 2021
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 21, 2022
Updates swift-markdown to include:
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 21, 2022
Updates swift-markdown to include:
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 21, 2022
Updates swift-markdown to include:
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 21, 2022
Updates swift-markdown to include:
commit 5fc007220571bf194930a98edeab7133156ab01c
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 12:20:47 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)`
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 21, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 21, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 22, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 22, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 22, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 22, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
to ethan-kusters/swift-docc
that referenced
this pull request
May 23, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (swiftlang#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (swiftlang#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (swiftlang#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (swiftlang#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
ethan-kusters
added a commit
that referenced
this pull request
May 25, 2022
Updates swift-markdown to include:
commit 97df6e2812adcf8698204ca5f0756563ef36e5c1
Author: Ethan Kusters <ekusters@apple.com>
Date: Sat May 21 14:02:22 2022 -0700
Correctly set `indexInParent` in `Markup.child(at:)` (#45)
This fixes a recent regression where `Markup.child(at:)` began returning
markup with incorrect metadata resulting in out-of-bounds errors.
The `indexInParent` value of a child is unrelated to the parent's
`indexInParent`. This was missed initially because tests were only
checking for children of the first item where `indexInParent` would
be 0. A new test has been added that asserts `Markup.child(at:)` returns
correct values for children of nested items as well.
commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b
Author: Ethan Kusters <ekusters@apple.com>
Date: Fri May 20 18:53:24 2022 -0700
Improve performance of `Markup.child(at:)` method (#44)
Improves the performance of `Markup.child(at:)` by refactoring to removing
the need to iterate over all previous elements in the child array.
commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204
Author: Franklin Schrans <fschrans@apple.com>
Date: Wed Mar 23 14:38:18 2022 +0100
Remove extraneous print in test (#33)
commit e50693584310a9190071c96c839485b6f2376832
Author: Ethan Kusters <ekusters@apple.com>
Date: Mon Mar 21 10:42:02 2022 -0700
Publish Swift Markdown's documentation to GitHub pages (#32)
* Adopt the Swift-DocC Plugin for documentation generation
* Add a script for publishing docs to GitHub pages
* Add missing license headers
* Move README docs to articles in the DocC catalog
* Remove out-of-date documentation about `DiagnosticEngine`
Swift markdown no longer includes a DiagnosticEngine so these links were failing
to resolve.
commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0
Author: christopherweems <github@christopherweems.com>
Date: Sat Mar 19 12:53:31 2022 -0400
Fix typo in documentation for `MarkupVisitor` (#26)
Co-authored-by: Christopher Weems <hello@christopherweems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates swift-argument-paser to 1.0.1. This also removes support for parsing unknown arguments in
docc convertDependencies
swiftlang/swift-markdown#17
swiftlang/swift#40103
swiftlang/swift-driver#899
swiftlang/sourcekit-lsp#434
swiftlang/swift-package-manager#3843
Testing
Run Cmd+U; ensure argument parsing still works.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded