Remove use of deprecated STSC 'Lock' #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artemcm
commented
Aug 23, 2022
artemcm
commented
- SwiftScan use of it seems not needed anymore
- ArgsResolver use can use 'NSLock' directly
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
cltnschlosser
approved these changes
Aug 23, 2022
compnerd
approved these changes
Aug 23, 2022
|
|
||
| fileprivate extension NSLock { | ||
| /// Execute the given block while holding the lock. | ||
| func withLock<T> (_ body: () throws -> T) rethrows -> T { |
Member
There was a problem hiding this comment.
Do we want to add a note to keep this in sync with SPM?
- SwiftScan use of it seems not needed anymore - ArgsResolver use can use 'NSLock' directly
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.