Remove extra options and regenerate from Swift's Options.td #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I've moved all the options into Options.td in swiftlang/swift#60813. This is the result of re-running |
bnbarham
force-pushed
the
remove-extra-options
branch
from
02d87c5 to
b012671
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I'm not sure if this is worth it or not without enforcing options not being added to |
artemcm
approved these changes
Aug 29, 2022
Remove `ExtraOptions.swift` to avoid new options being added there and not in the old driver, at least until all clients are moved off the old driver completely.
bnbarham
force-pushed
the
remove-extra-options
branch
from
b012671 to
da410db
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
|
Looks like this broke the CMake build, fixing in #1166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
ExtraOptions.swiftto avoid new options being added there andnot in the old driver, at least until all clients are moved off the old
driver completely.