Add ability to override/disable response file use in ArgsResolver #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
owenv
approved these changes
Aug 29, 2022
nkcsgexi
approved these changes
Aug 29, 2022
bnbarham
approved these changes
Aug 30, 2022
This change deprecates 'ArgsResolver' API that takes a boolean 'forceResponseFiles' in favour of a new API that takes an 'ResponseFileHandling' enum. This enum allows the previous behaviors of '.forced' and '.heuristic' ('true' and 'false', respectively of 'forceResponseFiles'), and adds an option to override disable use of response files completely ('.disabled').
This is useful in the example of dependency scanning when it is done via a C interface to a compiler library: even for exceedingly long command-line argument lists, using response files is not necessary since we just pass in a pointer to an already-allocated memory buffer containing the argument list, directly.
Resolves rdar://99296444
artemcm
force-pushed
the
NoResponseInLibraryScan
branch
from
b9b874f to
c86aaca
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates
ArgsResolverAPI that takes a booleanforceResponseFilesin favor of a new API that takes anResponseFileHandlingenum. This enum allows the previous behaviors of.forcedand.heuristic(trueandfalse, respectively offorceResponseFiles), and adds an option to override disable use of response files completely (.disabled).This is useful in the example of dependency scanning when it is done via a C interface to a compiler library: even for exceedingly-long command-line argument lists, using response files is not necessary since we just pass in an address of an already-allocated memory buffer containing the argument list, directly.
Resolves rdar://99296444