Add a Dot serializer for the inter-module dependency graph. #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
nkcsgexi
approved these changes
Sep 8, 2022
bnbarham
approved these changes
Sep 9, 2022
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
Nice :). Love me some dependency graphs!
Comment on lines
1219
to
1224
| let outputFile = path.appending(component: "dependency_graph.dot") | ||
| var outputStream = try! ThreadSafeOutputByteStream(LocalFileOutputByteStream(outputFile)) | ||
| serializer.writeDOT(to: &outputStream) | ||
| outputStream.flush() | ||
| let contents = try localFileSystem.readFileContents(outputFile).description | ||
| print(contents) |
Contributor
There was a problem hiding this comment.
Are you purposefully texting writing out here, or can this just be an in-memory string?
Also there's a couple of try! here but this is just a test and the method already throws, so they don't really seem needed.
Contributor
Author
There was a problem hiding this comment.
The primary use for this will be writing out to some kind of output stream so it doesn't hurt to use as such here.
Removed the try!, thanks!
Contributor
There was a problem hiding this comment.
I was imagining you'd test that with the option when it's added. But I don't really mind either way 🤷
It can be nice to be able to visualize all of a module's dependencies.
artemcm
force-pushed
the
DOT_ModuleGraphSerializer
branch
from
1b7efb3 to
b35358f
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be nice to be able to visualize all of a module's dependencies.
A followup change will wire it up to a driver flag to allow an arbitrary driver invocation to emit this to a specified path.
(Such flags must first be added in the main
swiftrepo)