[Sanitizers] Add support for -sanitize=memtag-stack #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sanitizer adds MTE (memory tagging extension) checks to stack variable accesses. It does not have a runtime library component, so some changes have been made to the driver logic to account for this cleanly.
DanBlackwell
requested review from
kateinoigakukun,
ndrewh,
thetruestblue,
usama54321,
wrotki and
yln
kateinoigakukun
approved these changes
Nov 15, 2025
Member
kateinoigakukun
left a comment
kateinoigakukun
left a comment
There was a problem hiding this comment.
Overall looks good to me, modulo the missing optional guard
| ) throws -> String? { | ||
| let environment = (targetTriple.environment == .android) ? "-android" : "" | ||
| return "libclang_rt.\(sanitizer.libraryName)-\(targetTriple.archName)\(environment).a" | ||
| return "libclang_rt.\(sanitizer.runtimeLibraryName)-\(targetTriple.archName)\(environment).a" |
Member
There was a problem hiding this comment.
Suggested change
| return "libclang_rt.\(sanitizer.runtimeLibraryName)-\(targetTriple.archName)\(environment).a" | |
| guard let runtimeLibraryName = sanitizer.runtimeLibraryName else { return nil } | |
| return "libclang_rt.\(runtimeLibraryName)-\(targetTriple.archName)\(environment).a" |
Author
There was a problem hiding this comment.
Thanks for the review! Good spot, I have added the guard now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sanitizer adds MTE (memory tagging extension) checks to stack variable accesses. It does not have a runtime library component, so some changes have been made to the driver logic to account for this cleanly.
The corresponding Swift change is at: swiftlang/swift#85515.
rdar://161721201