[6.3] Wasm: bump default stack size to 128K #2030
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default of 64K is too low, especially as tail calls are not available by default on Wasm. It also means Swift Testing is unusable in `main` development snapshots due to stack overflows. rdar://160218251
Contributor
Author
|
@swift-ci test |
The current invocation as is leads to `wasm-ld: error: unknown argument: --stack-size=131072`
Adjust `SwiftDriverTests/testLinking` for correct CLI options format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2026.
Explanation: The default of 64K for stack size is too low, especially as tail calls are not available by default on Wasm. It also means Swift Testing is unusable in
maindevelopment snapshots due to stack overflows.Scope: Limited to Wasm support.
Risk: Low due to isolated scope.
Testing: Added automated end-to-end test in swiftlang/swift-integration-tests#167.
Issue: rdar://160218251
Reviewer: @kateinoigakukun