Run part of async main synchronously #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Sep 9, 2021
| * Authors: [Evan Wilde](https://github.com/etcwilde) | ||
| * Review Manager: TBD | ||
| * Status: **Awaiting Implementation** | ||
|
|
There was a problem hiding this comment.
Please add links to the pitches and implementation
I'm proposing that we don't place the whole main function on the task queue, but instead run everything from the start of the program to the first suspension point synchronously so that programmers may ensure that initialization code is run before the runloop is running. Additionally, I'd like to propose that the main function is implicitly annotated with the @mainactor annotation and that it inherit the priority of the main thread.
etcwilde
force-pushed
the
ewilde/async-main
branch
from
804e9a0 to
151ade5
Compare
Applying editorial changes recommended by Ben. Thanks! Co-authored-by: Ben Rimmington <me@benrimmington.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing that we don't place the whole main function on the task
queue, but instead run everything from the start of the program to the
first suspension point synchronously so that programmers may ensure that
initialization code is run before the runloop is running.
Additionally, I'd like to propose that the main function is implicitly
annotated with the @mainactor annotation and that it inherit the
priority of the main thread.
I have this proposal partially implemented here: swiftlang/swift#38604