New Actor Initializer Proposal #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
changed the title
kavon
changed the title
kavon
force-pushed
the
actor-initializers-review2
branch
from
e755d31 to
3da47c2
Compare
kavon
force-pushed
the
actor-initializers-review2
branch
from
3da47c2 to
0ead581
Compare
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
reviewed
Dec 8, 2021
ktoso
approved these changes
Dec 9, 2021
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looking good, thanks for all the work here!
Contributor
|
(feel free to just resolve all comments) |
kavon
force-pushed
the
actor-initializers-review2
branch
from
f94be2c to
6b93ff9
Compare
ktoso
pushed a commit
that referenced
this pull request
Jan 5, 2022
* Draft of new version for 2nd round of review * explain that GAICs only need flow-isolation on non-isolated inits * rewrite explaination of how delegation, isolation, and sendable interact. * GAIC to GAIT, since it's more than classes * add an example touching on an edge-case. * pitching the precise rule for default values * clarify false sharing * further clarify stored property solution * fix some wording * go with `nonisolated` default-value expressions * updates to "Global-actor isolation and instance members"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version drops the escaping-use restriction and unifies the initializers under the concept of flow-sensitive actor isolation. It also covers deinits, sendability, etc.