Skip to content

Mark SE-0365 as implemented in Swift 5.8 #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Mark SE-0365 as implemented in Swift 5.8 #1836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions proposals/0365-implicit-self-weak-capture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* Proposal: [SE-0365](0365-implicit-self-weak-capture.md)
* Author: [Cal Stephens](https://github.com/calda)
* Review Manager: [Saleem Abdulrasool](https://github.com/compnerd)
* Status: **Accepted (2022-08-08)**
* Implementation: [apple/swift#40702](https://github.com/apple/swift/pull/40702)
* Status: **Implemented (Swift 5.8)**
* Implementation: [apple/swift#40702](https://github.com/apple/swift/pull/40702), [apple/swift#61520](https://github.com/apple/swift/pull/61520)

## Introduction

Expand Down Expand Up @@ -227,3 +227,5 @@ That would effectively add implicit control flow, however. `dismiss()` would onl
Thanks to the authors of [SE-0269](https://github.com/apple/swift-evolution/blob/main/proposals/0269-implicit-self-explicit-capture.md) for laying the foundation for this proposal.

Thanks to Kyle Sluder for [the suggestion](https://forums.swift.org/t/allow-implicit-self-for-weak-self-captures-after-self-is-unwrapped/54262/2) to not permit implicit `self` in cases where the unwrapped `self` value doesn't necessarily refer to the closure's `self` capture, like in `let self = self ?? C.global`.

Many thanks to Pavel Yaskevich, John McCall, and Xiaodi Wu for providing significant feedback and advice regarding the implementation of this proposal.