-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add package-access-modifier proposal #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, here's my initial review as review manager. I'll take a look at the pitch thread tomorrow.
Notes from the review thread:
|
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
eb6a0f8
to
bf5fda2
Compare
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Would it be useful to link to SwiftPM's scoped identifier documentation? |
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
9a387f8
to
3ae9ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. This should be the final pass. Looking very close to ready!
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
No description provided.