Skip to content

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Dec 12, 2022

No description provided.

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, here's my initial review as review manager. I'll take a look at the pitch thread tomorrow.

@rjmccall
Copy link
Contributor

rjmccall commented Jan 5, 2023

Notes from the review thread:

  • Alternatives Considered should contrast this proposal with the idea of introducing submodules. Maybe we should talk that over offline at some point.
  • Per Tony Allevato's comment, please discuss the possibility of enforcing that this isn't actually done outside of the package. (This would be possible if e.g. you had to pass the complete set of modules in the package to the compiler.)
  • The discussion about dead-stripping and other optimization should be fleshed out.
  • Please discuss the expected interaction of packages with library evolution. (e.g. this comment)

elsh and others added 8 commits January 18, 2023 22:45
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
@elsh elsh force-pushed the es-pkg-acl branch 2 times, most recently from eb6a0f8 to bf5fda2 Compare January 19, 2023 09:13
elsh and others added 4 commits January 24, 2023 11:33
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
@benrimmington
Copy link
Contributor

Would it be useful to link to SwiftPM's scoped identifier documentation?

elsh and others added 5 commits January 24, 2023 17:18
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
elsh and others added 5 commits January 25, 2023 11:16
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
@elsh elsh force-pushed the es-pkg-acl branch 2 times, most recently from 9a387f8 to 3ae9ce6 Compare January 25, 2023 21:59
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. This should be the final pass. Looking very close to ready!

elsh and others added 3 commits January 26, 2023 14:03
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
Co-authored-by: John McCall <rjmccall@apple.com>
@rjmccall rjmccall merged commit 3986868 into main Jan 26, 2023
@elsh elsh deleted the es-pkg-acl branch January 27, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants