Skip to content

Conversation

@ahoppen
Copy link
Member

@ahoppen ahoppen commented Nov 14, 2025

Depends on swiftlang/github-workflows#193 so the check-swift-format.sh script can pick up a locally built swift-format executable


The diff yields more insightful results than swift-format lint. Example of how the failures look like now: https://github.com/swiftlang/swift-format/actions/runs/19634366801/job/56221408873

@ahoppen ahoppen force-pushed the diff-pilot-projects branch 2 times, most recently from 14cfcd1 to 2ee5237 Compare November 14, 2025 18:14
@ahoppen ahoppen force-pushed the diff-pilot-projects branch 2 times, most recently from f11f40c to 6d231de Compare November 24, 2025 11:52
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Nov 24, 2025
…t.sh`

This allows us to override the `swift-format` executable to a locally built copy by adding the locally built version to PATH in swiftlang/swift-format#1093.
@ahoppen ahoppen force-pushed the diff-pilot-projects branch 2 times, most recently from 5d1ea9d to c529d8e Compare November 24, 2025 12:30
@ahoppen ahoppen force-pushed the diff-pilot-projects branch from c529d8e to c479157 Compare November 24, 2025 12:42
@ahoppen ahoppen marked this pull request as ready for review November 24, 2025 12:44
@ahoppen ahoppen requested a review from shahmishal as a code owner November 24, 2025 12:44
@ahoppen ahoppen requested a review from allevato November 24, 2025 12:46
The diff yields more insightful results than `swift-format lint`
@ahoppen ahoppen force-pushed the diff-pilot-projects branch from c479157 to 00daa3e Compare November 24, 2025 12:47
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants