Skip to content

Conversation

@shahmishal
Copy link
Member

No description provided.

@parkera
Copy link
Contributor

parkera commented Mar 10, 2025

This is built for the toolchain, so we shouldn’t be building back deployment packages for Swift 5.9, or probably even 6.0.

@parkera
Copy link
Contributor

parkera commented Mar 10, 2025

Like swift-foundation the package support is mainly a local development aid, so it should still build as a package for main. I’m on the fence about supporting one version back as a package. It’ll probably work most of the time.

@parkera
Copy link
Contributor

parkera commented Mar 10, 2025

Is it possible to have this CI build and test swift-foundation? That is where we will really see if a change here is going to break something.

@shahmishal
Copy link
Member Author

Is it possible to have this CI build and test swift-foundation? That is where we will really see if a change here is going to break something.

Would it be possible to add this part of the package test? swift test

@shahmishal
Copy link
Member Author

Like swift-foundation the package support is mainly a local development aid, so it should still build as a package for main. I’m on the fence about supporting one version back as a package. It’ll probably work most of the time.

It's easy to reduce the scope here, let me only test nightly-main and nightly-6.1.

@parkera
Copy link
Contributor

parkera commented Mar 12, 2025

How do we rerun the checks and verify that the Windows 5.9 check is no longer being run (and failing)?

@compnerd
Copy link
Member

How do we rerun the checks and verify that the Windows 5.9 check is no longer being run (and failing)?

If you click on the job it self, it will take you to the details for it. There, at the top right you will find a button to re-run the job.

@parkera
Copy link
Contributor

parkera commented Mar 12, 2025

I don't want to rerun the Windows check for 5.9 though - I don't want it in the configuration at all. :)

@parkera
Copy link
Contributor

parkera commented Mar 12, 2025

Same for all 5.9, 5.8 or anything pre-6.0 for all platforms.

@shahmishal
Copy link
Member Author

Same for all 5.9, 5.8 or anything pre-6.0 for all platforms.

Updated in bf3a258

@shahmishal shahmishal merged commit 2543ac6 into main Mar 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants