Android: Remove _Builtins_float
#415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_Builtins_float` was added in swiftlang#406 for the Android package. However, this module does not exist so this removes it.
Steelskin
requested review from
compnerd,
etcwilde and
shahmishal
as code owners
compnerd
requested changes
Apr 21, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
No, this was intentionally added - this should be built.
Contributor
Author
|
Not the right fix, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Builtins_floatwas added in #406 for the Android package. However, this module does not exist so this removes it.